8000 Mention Conan in README.md by chausner · Pull Request #135 · jbaldwin/libcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mention Conan in README.md #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Mention Conan in README.md #135

merged 2 commits into from
Apr 14, 2023

Conversation

chausner
Copy link
Contributor

This adds a note to README.md about the availability of libcoro via the Conan package manager.

@jbaldwin
Copy link
Owner
jbaldwin commented Apr 12, 2023

Does this require builds to be made an uploaded to the Conan package manager?

I've never used it so wondering what the process is and if we can automate it when a new tagged version is created.

@chausner
Copy link
Contributor Author
chausner commented Apr 12, 2023

The Conan package manager resolves libraries via so-called recipes from Conan Center which is the official default repository. Recipes basically tell Conan where the library source is located and how it can be built. Conan Center also hosts binary builds for packages for a number of platform/compiler combinations. So when a client installs the libcoro package via Conan, it will either download a prebuilt binary from Conan Center if available for the client platform/compiler, or it will build the library on-the-fly using the build instructions in the recipe.

Conan Center is maintained by the community as a repository on GitHub: https://github.com/conan-io/conan-center-index/. Everyone can submit new recipes or recipe updates via Pull Requests. I already did the necessary work to write a recipe for the current version of libcoro: conan-io/conan-center-index#16877.

When a new version of libcoro is published, someone will need to manually update the recipe so that the new version is available on Conan Center. If nothing changed in the build process, it is trivial to update the recipe (basically one only needs to add the GitHub URL of the new version tag, like here). If there are changes in how the library is built, more changes might be needed.
In general, it is not expected that you update it (although you are free to submit recipe updates yourself, if you want). Ideally someone from the Conan community will update the recipe soon after a new release is made but in general, there is of course no guarantee that Conan Center always hosts the latest version of all libraries since it is a community effort.

@chausner
Copy link
Contributor Author
chausner commented Apr 12, 2023

By the way, I also submitted a port of libcoro to the vcpkg package manager: microsoft/vcpkg#30623. The process there to get library ports updated is very similar. Unfortunately, their CI currently runs gcc 9 which is too old for libcoro, so they decided to not merge my PR for now until they update their CI pipeline. But I hope that sometime in the future, libcoro will also be available on vcpkg.

@jbaldwin
Copy link
Owner

Thanks, I appreciate the in depth explanation. Seems straight forward enough. That's too bad on vcpkg! Hopefully they can get on a more recent compiler 😃

Copy link
Owner
@jbaldwin jbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change actually needs to be in the readme-template.md file otherwise it will be blown away by the commit process. It injects all the built examples via macros/tokens so they don't have to be manually copied and pasted. Can you move it there please?

@chausner
Copy link
Contributor Author

Sure, I copied the changes to readme-template.md.

@jbaldwin
Copy link
Owner

Thanks!

@jbaldwin jbaldwin merged commit d863399 into jbaldwin:main Apr 14, 2023
@chausner chausner deleted the patch-1 branch June 16, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0