8000 Add: CI for MSVC. by bjones1 · Pull Request #188 · jbaldwin/libcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add: CI for MSVC. #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2023
Merged

Add: CI for MSVC. #188

merged 6 commits into from
Oct 22, 2023

Conversation

bjones1
Copy link
Contributor
@bjones1 bjones1 commented Oct 16, 2023

Add CI coverage for the MSVC compiler.

@bjones1 bjones1 force-pushed the msvc-ci branch 2 times, most recently from 6257a67 to 6ee62d5 Compare October 16, 2023 01:41
@bjones1 bjones1 marked this pull request as ready for review October 16, 2023 02:06
@bjones1
Copy link
Contributor Author
bjones1 commented Oct 16, 2023

Here's CI for MSVC, per the request in #184. Currently, it's failing until #184 is merged. There will probably be a few more bugs to fix after that, as well.

@bjones1 bjones1 mentioned this pull request Oct 16, 2023
Merged
@bjones1
Copy link
Contributor Author
bjones1 commented Oct 18, 2023

I merged in the latest from main, then added fixes required to get CI passing with MSVC. Success!

@jbaldwin
Copy link
Owner

Nice! I'll get this one merged. Awesome work.

jbaldwin
jbaldwin reviewed Oct 22, 2023
View reviewed changes
@jbaldwin jbaldwin merged commit 398cc0c into jbaldwin:main Oct 22, 2023
@bjones1 bjones1 deleted the msvc-ci branch October 22, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaldwin jbaldwin jbaldwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjones1 @jbaldwin
0