Make clock using statements public for users #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ripose-jp please review if you have some time, I think this is a good solution to your PR you opened recently. |
The clock using statements were hidden away in a details poll_info file which made it confusing for what to pass into certain scheduler functions. This makes the using statements public so its clear the user can use them (or the underlying chrono types) easily. Closes #217
39e0241 to
02d2ae1
Compare
|
dnf mirrors seem to be having issues today, going to wait until tomorrow to see if fedora 36 gets 'fixed'. |
|
The example from my issue compiles after changing the namespaces and the code LGTM. |
ripose-jp
approved these changes
Nov 25, 2023
|
🎉 fedora-36 finally fixed their mirror problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clock using statements were hidden away in a details poll_info file which made it confusing for what to pass into certain scheduler functions. This makes the using statements public so its clear the user can use them (or the underlying chrono types) easily.
Closes #217