Update mac os ci workflow to use newer version of llvm and mac os #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaldwin
requested changes
May 9, 2025
|
You are absolutely correct.. that should not have compiled before 😬 I left a note on the move constructor/operator.. preference is probably to just |
jbaldwin
approved these changes
May 10, 2025
|
Hmm seems like one test timed out without actually running the tests? I think this is not related to the changes made in this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the CI for MacOS. I had to add some missing headers and I had to make some changes to the move constructor of
coro::queuethat you should review because I honestly have no idea how you got that to compile prior to my changes (your mutex class is not move constructible but is moved in the move constructor of queue).