forked from algorand/go-algorand
-
Notifications
You must be signed in to change notification settings - Fork 0
Extend debugger interface #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jdtzmn
wants to merge
426
commits into
psuedo-eval-endpoint
Choose a base branch
from
extend-debugger-interface
base: psuedo-eval-endpoint
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Aug 17, 2022
jasonpaulos
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
My one comment is that it would be nice to see a unit test or two for the changes in data/transactions/verify/txn.go
, but that can be done in a different place before release
3 tasks
add match opcode along with assembler and eval unit tests implementation of match, pushints, and pushbytess add docs for pushints and pushbytess
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
v36 consensus upgrade
Changed assembler functionality so that logic.assemble errors when receiving empty input
go-algorand v3.13.3-stable
…-3-13-3-remerge
* Decrease connections per ip addr limit to 15
* Updating action versions * Removing inlining and optimizations from building partitiontest-linter * Adding flags to golangci-lint * Syncing typeparams dependency version * Changing tools package version * running go mod tidy and adding compat 1.17 * Chris's fix for linter * Filtering on added only, upgrading reviewdog, diplaying errors in log
* Fix t.Parallel() errors in shared package * Correct .golangci.yml paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR includes an extended debugger interface which extends the existing
logic.DebuggerHooks
interface with additional events which will become useful within the simulator.The PR currently points to the wrong base to make it easier to see what files have been changed since then while gathering initial reviews.
Test Plan
debugger_test.go
for the new hookseval.TransactionGroupWithDebugger()
withineval_test.go