8000 Extend debugger interface by jdtzmn · Pull Request #4 · jdtzmn/go-algorand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extend debugger interface #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 426 commits into
base: psuedo-eval-endpoint
Choose a base branch
from

Conversation

jdtzmn
Copy link
Owner
@jdtzmn jdtzmn commented Aug 16, 2022

Summary

This draft PR includes an extended debugger interface which extends the existing logic.DebuggerHooks interface with additional events which will become useful within the simulator.

The PR currently points to the wrong base to make it easier to see what files have been changed since then while gathering initial reviews.

Test Plan

  • Additional tests in debugger_test.go for the new hooks
  • Test eval.TransactionGroupWithDebugger() within eval_test.go

@jdtzmn jdtzmn requested a review from jasonpaulos August 18, 2022 19:21
Copy link
@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

My one comment is that it would be nice to see a unit test or two for the changes in data/transactions/verify/txn.go, but that can be done in a different place before release

michaeldiamant and others added 26 commits October 26, 2022 15:15
add match opcode along with assembler and eval unit tests
implementation of match, pushints, and pushbytess
add docs for pushints and pushbytess
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
jasonpaulos and others added 30 commits January 12, 2023 10:44
Changed assembler functionality so that logic.assemble errors when receiving empty input
* Updating action versions
* Removing inlining and optimizations from building partitiontest-linter
* Adding flags to golangci-lint
* Syncing typeparams dependency version
* Changing tools package version
* running go mod tidy and adding compat 1.17
* Chris's fix for linter
* Filtering on added only, upgrading reviewdog, diplaying errors in log
* Fix t.Parallel() errors in shared package
* Correct .golangci.yml paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0