8000 typo - do instead of don't by catherinetsang · Pull Request #8518 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

typo - do instead of don't #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2020
Merged

typo - do instead of don't #8518

merged 3 commits into from
Dec 31, 2020

Conversation

catherinetsang
Copy link
Contributor

Summary

Context

@ashmaroli
Copy link
Member

@catherinetsang Thank you for improving our docs.
Though the change is fine as is, I now realize that the paragraph itself doesn't flow smoothly while reading.

Will you be able to rephrase the whole paragraph to read better? If not, this will get merged anyways.

@catherinetsang
Copy link
Contributor Author

@ashmaroli Sure thing. Let me try to rephrase it

catherinetsang
catherinetsang commented Dec 25, 2020
View reviewed changes
Rephrased with hyperlink to wiki page on BOM
cf0738f 
Added a bit more detail to make it beginner friendly, tried to include where the BOM is located and a hyperlink to see what the byte sequence could look like
DirtyF
DirtyF approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member
@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catherinetsang 🙏🏻

@DirtyF
Copy link
Member
DirtyF commented Dec 31, 2020

@jekyll: merge +docs

@jekyllbot jekyllbot merged commit 52fd945 into jekyll:master Dec 31, 2020
jekyllbot added a commit that referenced this pull request Dec 31, 2020
@jekyllbot
Update history to reflect merge of #8518 [ci skip]
deb1a71
github-actions bot pushed a commit to tigefa4u/jekyll that referenced this pull request Dec 31, 2020
@tigefa4u
Deploy docs from deb1a71
e9bd274 
jekyllbot: Update history to reflect merge of jekyll#8518 [ci skip]
github-actions bot pushed a commit that referenced this pull request Dec 31, 2020
@jekyllbot
Deploy docs from 52fd945
99115a2 
Curious Cat: typo - do instead of don't (#8518)

Merge pull request 8518
@jekyll jekyll locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli left review comments

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catherinetsang @ashmaroli @DirtyF @jekyllbot
0