8000 Fix `--livereload-ignore` option by mslinn · Pull Request #9570 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix --livereload-ignore option #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2024
Merged

Fix --livereload-ignore option #9570

merged 4 commits into from
Sep 11, 2024

Conversation

mslinn
Copy link
Contributor
@mslinn mslinn commented Mar 28, 2024

This is a 🐛 bug fix.

Summary

Makes livereload_ignore finally work properly.

Context

Fixes #9502

@mslinn
Fixes jekyll#9502
7e0cfec 
Makes `livereload_ignore` finally work properly.
@ashmaroli
Copy link
Member

Hello @mslinn,
My local tests show that your changes doesn't actually fix the livereload_ignore at my end. I would normally ask you to add tests but for now, could you add some log outputs or puts calls and confirm that your test ignore_pattern is actually respected.

@ashmaroli ashmaroli added this to the 4.4 milestone Sep 11, 2024
@ashmaroli ashmaroli changed the title Fixes #9502 Fix --livereload-ignore option Sep 11, 2024
@ashmaroli
Copy link
Member

Thanks @mslinn
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 0fde781 into jekyll:master Sep 11, 2024
11 checks passed
jekyllbot added a commit that referenced this pull request Sep 11, 2024
@jekyllbot
Update history to reflect merge of #9570 [ci skip]
bc443c2
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@jekyllbot
Deploy docs from 0fde781
32ef288 
Mike Slinn: Fix `--livereload-ignore` option (#9570)

Merge pull request 9570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Bug]: livereload-ignore option doesn't work
3 participants
@mslinn @ashmaroli @jekyllbot
0