fix(ingress): github webhooks weren't being updated on jx upgrade ingress
#2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentgonzo
commented
Jan 7, 2019
| } | ||
|
|
||
| if isProwEnabled { | ||
| webHookArgs.Secret = string(hmacToken.Data["hmac"]) | ||
| } | ||
|
|
||
| log.Infof("Updating WebHook with new args\n") |
There was a problem hiding this comment.
This lead to confusion when nothing actually happened (see @jtnord 's comments) and is better removed as we have sufficient logging in the UpdateWebHook method
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtnord The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jx upgrade ingresswasn't correctly setting the webhooks in github.It was incorrectly checking whether the webhook matched the new URL (that you were trying to set it to)
fixes #2018