Look further back to handle LTS.4/LTS.1 dual release days #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
approved these changes
Sep 25, 2019
slide
approved these changes
Sep 25, 2019
jeffret-b
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
I don't know that this will solve the problem -- I haven't tried it or seen what the results look like. But, it's plausible that this could be the issue and it doesn't seem like it would hurt.
Is there any particular reason for the magic number of 30? Is that just increasing it by 50%?
20 isn't enough (by ~3), so 25 could have done it. 30 to add a bit of padding: Conceivably there could have been 1-2 more weeklies between the baselines, or another LTS release delay… |
olblak
approved these changes
Sep 25, 2019
We're not republishing images that already exist. |
|
Before: After: 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We published both 2.176.4 and 2.190.1 today to allow admins to apply security fixes without having to perform a major update.
Unfortunately, no images for 2.176.4 were generated, and I think this is the reason.
So look back further.