8000 amex cards should always have a 4 digit cvc. by stevemckenzie · Pull Request #181 · jessepollak/card · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

amex cards should always have a 4 digit cvc. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

amex cards should always have a 4 digit cvc. #181

wants to merge 1 commit into from

Conversation

stevemckenzie
Copy link

No description provided.

8000
@stevemckenzie stevemckenzie mentioned this pull request Jun 22, 2015
Closed
@jessepollak
Copy link
Owner

Thanks for this! Can you make the change in the .coffee file then build?

@stevemckenzie
Copy link
Author

@jessepollak i haven't dealt with submodules in a while. the coffee side is in a different repo.

PR for that here - jessepollak/payment#10

I didn't update this repo to point to that commit. Should I be doing that too?

I'm also not a coffeescript person so can you explain more on what you want me to do on that side?

@jessepollak
Copy link
Owner

Thanks for doing that upstream @stevemckenzie! I'm closing this as I think we're good to go here, then I'll merge in your PR and ship it in the next release (hopefully today).

@stevemckenzie
Copy link
Author

Thanks @jessepollak 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevemckenzie @jessepollak
0