Change name of values initializer to placeholders
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome, thank you! 🎉🎊💫✨🎈 |
jessepollak
pushed a commit
that referenced
this pull request
Jul 18, 2015
Change name of `values` initializer to `placeholders`
|
Thanks for the easy intro! |
|
Thanks, does make more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #185, this pull request changes the name used to refer to the default placeholder values for the card visualisation from 'values' to 'placeholders' and updates the documentation accordingly.
This change should hopefully lead to less confusion as the placeholder values do not work as regular values, and so the distinct naming helps to clarify this.