8000 improvement: colorize the menu items for better visibility by dwightmulcahy · Pull Request #3 · jererobles/airq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

improvement: colorize the menu items for better visibility #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dwightmulcahy
Copy link
Contributor
@dwightmulcahy dwightmulcahy 8000 commented Nov 3, 2021

better visibility of sensors that are out of range by using the "color" field that is passed back in the json.

@jererobles
Copy link
Owner

Brilliant idea. Also the new text alignment makes reading values much easier. One thing I didn't consider was that the API could return different temperature units based locale, sorry about that. For some reason though it's still showing Celsius for me where it should be Fahrenheit (see screenshots), perhaps it should just the user's unit of choice. On that vein, I opened a branch to bring customizable info on the menu bar but it's far from complete unfortunately.

BTW, was the warning icon removed for values outside the healthy threshold? Doesn't show up for me e.g. for CO2:

Screenshot 2021-11-06 at 9 12 21Screenshot 2021-11-06 at 9 12 33

@dwightmulcahy
Copy link
Contributor Author
dwightmulcahy commented Nov 8, 2021

was the warning icon removed for values outside the healthy threshold? Doesn't show up for me e.g. for CO2:

So I dropped the icon in favor of the color that Uhoo json returns. Looking at Uhoo app it considers 1000ppm to be the "yellow" category... was your intent at setting the CO2 warning levels based on some other standard?

One thing I didn't consider was that the API could return different temperature units based locale

I'll take a look at that...

I opened a branch to bring customizable info

I was going to look at adding a "preference" option to the menu to set stuff like the api, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0