8000 Create CI Workflows by alexevladgabriel · Pull Request #52 · jetkvm/kvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create CI Workflows #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Create CI Workflows #52

wants to merge 10 commits into from
+217 −0

Conversation

alexevladgabriel
Copy link
Contributor
@alexevladgabriel alexevladgabriel commented Jan 7, 2025 •
edited
Loading

Changelogs:

  • Includes workflows for creating binaries on new releases and pr's for being able to test them.

Workflows:

  • Release
  • Push

@alexevladgabriel alexevladgabriel marked this pull request as draft January 7, 2025 23:07
@Nevexo
Copy link
Contributor
Nevexo commented Jan 7, 2025 •
edited
Loading

Just so it's in the GH history: Discord Thread

PR builds should include the commit hash of the latest commit in the PR's branch

@kashalls
Copy link
kashalls commented Jan 7, 2025 •
edited
Loading

Can you pass both a Version and a Gitsha instead of just the ref?

go build -ldflags "-s -w -X kvm.Version=${VERSION} -X kvm.Gitsha=${REVISION}" ./cmd/main.go

Version is the Semver Tag and Gitsha is the sha of the git commit it is building on.

kashalls
kashalls reviewed Jan 8, 2025
View reviewed changes
@alexevladgabriel alexevladgabriel marked this pull request as ready for review January 8, 2025 00:53
@CLAassistant
Copy link
CLAassistant commented Feb 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

IDisposable
IDisposable reviewed Jun 13, 2025
View reviewed changes
.github/workflows/push.yaml
GOOS: ${{ matrix.goos }}
GOARCH: ${{ matrix.goarch }}
run: |
GOOS=linux GOARCH=arm GOARM=7 go build -ldflags="-s -w -X kvm.builtAppVersion=dev-${GIT_COMMIT:0:7}" -o bin/jetkvm_app cmd/main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've entered the matrix, then this line should use it :)

GOOS=${matrix.goos} GOARCH=${matrix.goarch} GOARM=7 go build -ldflags="-s -w -X kvm.builtAppVersion=dev-${GIT_COMMIT:0:7}" -o bin/jetkvm_app cmd/main.go

@IDisposable
Copy link
Contributor

Might it be better to execute the Makefile instead duplicating the one line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable left review comments

@kashalls kashalls kashalls left review comments

Assignees
No one assigned
Labels
build-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexevladgabriel @Nevexo @kashalls @CLAassistant @IDisposable
0