chore: disable cgo #601
Merged
chore: disable cgo #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables CGO for ARM/Linux cross-compilation by updating the build command.
- Adds
CGO_ENABLED=0toGO_CMDfor static binary builds.
Comments suppressed due to low confidence (1)
Makefile:18
- [nitpick] Add a brief comment explaining why
CGO_ENABLED=0is set (e.g., to produce a statically linked binary) to improve clarity for future maintainers.
GO_CMD := GOOS=linux GOARCH=arm GOARM=7 CGO_ENABLED=0 go
|
Yay! |
ariedel87
pushed a commit
to ariedel87/kvm
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#21083
related to #534