network enhanecment / refactor #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 72 out of 74 changed files in this pull request and generated no comments.
Files not reviewed (2)
- dev_deploy.sh: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
internal/confparser/confparser.go:208
- The type assertion f.CurrentValue.(reflect.Value) assumes that f.CurrentValue is always a reflect.Value when delegated. This may lead to a runtime panic if the assumption is violated. Consider adding a type check or handling cases where f.CurrentValue is not a reflect.Value.
if required && f.Delegated { if err := setDefaultsAndValidate(f.CurrentValue.(reflect.Value).Interface(), false); err != nil {
display.go:182
- [nitpick] The parameter name 'shouldWakeDisplay' could be made clearer by adding a comment to explain when waking the display is desired. This helps improve code readability and maintainability.
func requestDisplayUpdate(shouldWakeDisplay bool) {
chemhack
approved these changes
Apr 15, 2025
|
Any idea when this will make it to release? |
This was referenced May 10, 2025
Closed
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Jun 13, 2025
* chore(network): improve connectivity check * refactor(network): rewrite network and timesync component * feat(display): show cloud connection status * chore: change logging verbosity * chore(websecure): update log message * fix(ota): validate root certificate when downloading update * feat(ui): add network settings tab * fix(display): cloud connecting animation * fix: golintci issues * feat: add network settings tab * feat(timesync): query servers in parallel * refactor(network): move to internal/network package * feat(timesync): add metrics * refactor(log): move log to internal/logging package * refactor(mdms): move mdns to internal/mdns package * feat(developer): add pprof endpoint * feat(logging): add a simple logging streaming endpoint * fix(mdns): do not start mdns until network is up * feat(network): allow users to update network settings from ui * fix(network): handle errors when net.IPAddr is nil * fix(mdns): scopedLogger SIGSEGV * fix(dhcp): watch directory instead of file to catch fsnotify.Create event * refactor(nbd): move platform-specific code to different files * refactor(native): move platform-specific code to different files * chore: fix linter issues * chore(dev_deploy): allow to override PION_LOG_TRACE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI/UX Improvements
Core Features
Developer Tools
/developer/log-stream