8000 Add support for `std::invoke`-like calls in `apply`. by jehelset · Pull Request #81 · jfalcou/kumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for std::invoke-like calls in apply. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

Add support for std::invoke-like calls in apply. #81

merged 1 commit into from
May 30, 2024

Conversation

jehelset
Copy link
Contributor

Also adds noexcept spec via is_nothrow_invocable type-trait.

@jehelset
Copy link
Contributor Author

@jfalcou i will add some more tests (hence draft), just wondering if general shape is ok.

@jfalcou
Copy link
Owner
jfalcou commented Dec 21, 2023

OOh forgot to reply here.

The failures :

/Users/runner/work/kumi/kumi/include/kumi/utils/apply.hpp:16:41: error: no template named 'unwrap_reference_t' in namespace 'std'; did you mean 'unwrap_reference'?
      !std::is_same_v<std::decay_t<std::unwrap_reference_t<T &&>>, std::unwrap_ref_decay_t<T &&>>;
                                   ~~~~~^~~~~~~~~~~~~~~~~~
                                        unwrap_reference
/Users/runner/Library/Android/sdk/ndk/25.2.9519653/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/utility:644:8: note: 'unwrap_reference' declared here
struct unwrap_reference : __unwrap_reference<_Tp> { };
       ^
In file included from /Users/runner/work/kumi/kumi/test/doc/adapt.cpp:6:
In file included from /Users/runner/work/kumi/kumi/include/kumi/tuple.hpp:[15](https://github.com/jfalcou/kumi/actions/runs/7024999372/job/19114937475#step:4:16):
In file included from /Users/runner/work/kumi/kumi/include/kumi/utils.hpp:34:
/Users/runner/work/kumi/kumi/include/kumi/utils/apply.hpp:[16](https://github.com/jfalcou/kumi/actions/runs/7024999372/job/19114937475#step:4:17):73: error: no template named 'unwrap_ref_decay_t' in namespace 'std'; did you mean 'unwrap_ref_decay'?
      !std::is_same_v<std::decay_t<std::unwrap_reference_t<T &&>>, std::unwrap_ref_decay_t<T &&>>;
                                                                   ~~~~~^~~~~~~~~~~~~~~~~~
                                                                        unwrap_ref_decay

comes from the incomplete android STL, just use typename unwrap<...>::type

jfalcou
jfalcou reviewed Dec 22, 2023
View reviewed changes
jfalcou
jfalcou reviewed Dec 22, 2023
View reviewed changes
@jfalcou jfalcou marked this pull request as ready for review December 22, 2023 18:35
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Add support for std::invoke-like calls in apply.
43c440d 
Also adds noexecpt spec via `is_nothrow_invocable` type-trait.
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Workaround incomplete android stl.
7ff8070
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Fix typo.
7b72e63
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Regenerate standalone header.
c441790
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Fixup some supporting traits and add some more tests.
1ed4e18
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Fixup typo in tests.
1dc5b54
jehelset added a commit to jehelset/kumi that referenced this pull request Dec 22, 2023
@jehelset
Fix jfalcou#81 - Add support for std::invoke-like calls in apply.
fe07d13 
Also adds noexcept spec.
@jfalcou jfalcou merged commit c6c63af into jfalcou:main May 30, 2024
24 checks passed
@jehelset jehelset deleted the jeh/apply branch June 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfalcou jfalcou jfalcou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jehelset @jfalcou
0