8000 Get method for size limitation on PR content by attiasas · Pull Request #133 · jfrog/froggit-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get method for size limitation on PR content #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub& 8000 rdquo;, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2024
Merged

Get method for size limitation on PR content #133

merged 1 commit into from
Mar 24, 2024

Conversation

attiasas
Copy link
Contributor
@attiasas attiasas commented Mar 14, 2024 •
edited
Loading
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, GitLab and Azure Repos.
  • I added the relevant documentation for the new feature.

Add new methods to get the size limitations for the pull request content (details/comments).
It allows us to figure out dynamically if the content will overflow and the API will result in failures.

Limitations found:

Github

Gitlab

  • Merge Request details limit: 1,048,576 chars docs
  • Merge Request comment content limit: 1,000,000 chars docs

BitBucket

  • Pull Request content limit: 32,768 chars:
11:07:00 [Error] couldn't add pull request comment: Status: 400 Bad Request, Body: {"errors":[{"context":"text","message":"Please enter a non-empty value less than 32768 characters","exceptionName":null}]}

Azure Repos

@attiasas attiasas added the new feature Automatically generated release notes label Mar 14, 2024
@attiasas attiasas requested a review from sverdlov93 March 14, 2024 13:50
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

sverdlov93
sverdlov93 reviewed Mar 14, 2024
View reviewed changes
@attiasas attiasas merged commit 8b10260 into jfrog:master Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @sverdlov93
0