8000 Fix race conditions by yahavi · Pull Request #32 · jfrog/gofrog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix race conditions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix race conditions #32

merged 1 commit into from
Oct 19, 2022

Conversation

yahavi
Copy link
Member
@yahavi yahavi commented Oct 19, 2022
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

Fix 2 race conditions in runner:

  1. False positive - two concurrent threads may set started boolean to true. Fixed by changing it to unit32 + atomic.
  2. Stop using "rndSrc" and "random" variables in tests. Instead, use rand.Intn(50).

@yahavi yahavi requested a review from omerzi October 19, 2022 14:01
@yahavi yahavi self-assigned this Oct 19, 2022
@yahavi yahavi temporarily deployed to frogbot October 19, 2022 14:01 Inactive
@github-actions
Copy link

What is Frogbot?

@yahavi yahavi added the bug Something isn't working label Oct 19, 2022
@yahavi yahavi merged commit 8c7b69d into jfrog:dev Oct 19, 2022
@yahavi yahavi deleted the race branch October 19, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi approved these changes

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @omerzi
0