8000 Added nil checks to sets union and intersect operations by noyshabtay · Pull Request #50 · jfrog/gofrog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added nil checks to sets union and intersect operations #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

Added nil checks to sets union and intersect operations #50

merged 1 commit into from
Jan 31, 2024

Conversation

noyshabtay
Copy link
Contributor
@noyshabtay noyshabtay commented Jan 31, 2024 •
edited
Loading
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

Added nil checks to sets union and intersect operations.
Some improvements in code format.

@noyshabtay noyshabtay added the improvement Automatically generated release notes label Jan 31, 2024
@noyshabtay noyshabtay requested a review from omerzi January 31, 2024 09:54
@noyshabtay noyshabtay self-assigned this Jan 31, 2024
@noyshabtay noyshabtay added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Jan 31, 2024
@noyshabtay noyshabtay changed the title Added nil check to sets union and intersect operations Added nil checks to sets union and intersect operations Jan 31, 2024
@noyshabtay noyshabtay merged commit 041a424 into dev Jan 31, 2024
@noyshabtay noyshabtay deleted the sets-finetune branch January 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi approved these changes

Assignees

@noyshabtay noyshabtay

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noyshabtay @omerzi
< 3170 div hidden> Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0