Added support for local binding. Closes #122 #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gou4shi1
reviewed
Apr 24, 2022
| Connection::ptr_t Connect(Context& ctx) { | ||
|
|
||
| static const auto timer_name = "Connect"s; | ||
|
|
||
| auto prot_filter = GetBindProtocols(properties_->bindToLocalAddress, ctx); |
There was a problem hiding this comment.
Only call GetBindProtocols() under if (!connection->GetSocket().IsOpen()) to save cost?
There was a problem hiding this comment.
It's the work-flow for new connections. All connection object instances are maintained by a connection-pool, and this block opens the connection if it is new.
There was a problem hiding this comment.
I thought we could move this line to line 411 to save cost if the connection is already open, but there is a loop in line 396 so it also makes sense to keep it here, nvm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.