8000 Markdown writer: convert definition lists to bullet lists if `definition_lists` option is disabled by link2xt · Pull Request #7287 · jgm/pandoc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Markdown writer: convert definition lists to bullet lists if definition_lists option is disabled #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Markdown writer: convert definition lists to bullet lists if definition_lists option is disabled #7287

wants to merge 1 commit into from

C 8000 onversation

link2xt
Copy link
Collaborator
@link2xt link2xt commented May 14, 2021

Fixes #1039

link2xt
link2xt commented May 14, 2021
View reviewed changes
test/command/1039.md

- Term 2

- - Definition 2.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how reader parses this, Definition 2.1 is parsed as definition, not label. So the result is not what #1039 author expected, but it's correct.

@link2xt
Copy link
Collaborator Author
link2xt commented May 14, 2021

Do not forget to "hide whitespace changes" when reviewing:
1

@link2xt link2xt requested a review from jgm May 14, 2021 22:04
@link2xt link2xt force-pushed the 1039-markdown-wirter-no_definition_lists-convert-to-bullet branch from 6322f6e to 5248485 Compare May 14, 2021 22:06
@link2xt link2xt force-pushed the 1039-markdown-wirter-no_definition_lists-convert-to-bullet branch from 5248485 to e17a1e3 Compare May 14, 2021 22:16
@jgm
Copy link
Owner
jgm commented May 14, 2021

Thanks for this! But I'm not quite sold on the proposal yet -- see my comment in the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgm jgm Awaiting requested review from jgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please render definition lists as nested unordered lists when definition_lists extension is disabled
2 participants
@link2xt @jgm
0