Update LaTeX writer to align images #2724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the LaTeX writer to align images that have an "align" attribute whose value is "left", "right" or "center". If the attribute is absent or has an unrecognised values, the image is left alone. Also update the RST reader to read these horizonal alignment values from the image directive (the first encountered value applies). See http://docutils.sourceforge.net/docs/ref/rst/directives.html#image for details.
|
+1 |
|
Although I cannot speak for @jgm, I guess for this to be merged, it would have to be implemented in the most commonly used writers (i.e. HTML probably emitting a |
|
Then again, 99b39ff meanwhile set a precedent to simply store alignment in the AST as simply a |
|
Stumbled over this as a blocker in my work today. Anything I can do to help move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the LaTeX writer to align images that have an "align"
attribute whose value is "left", "right" or "center". If the
attribute is absent or has an unrecognised values, the image is left
alone.
Also update the RST reader to read these horizonal alignment values
from the image directive (the first encountered value applies). See
http://docutils.sourceforge.net/docs/ref/rst/directives.html#image
for details.