[tex] Positioning of figures #3180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f38236 to
e7fe7fb
Compare
|
Any objections to having such a feature in the LaTeX writer? I added more info in the commit message. |
e7fe7fb to
8fdc7ff
Compare
jgm
reviewed
Nov 16, 2016
tests/writer.latex
Outdated
| @@ -923,7 +923,7 @@ or here: <http://example.com/> | |||
|
|
|||
| From ``Voyage dans la Lune'' by Georges Melies (1902): | |||
|
|
|||
| \begin{figure} | |||
| \begin{figure}[] | |||
There was a problem hiding this comment.
In any case we should avoid empty brackets when there are no options.
|
One concern I have is that |
909ff06 to
656df95
Compare
|
@jgm Thanks, I wasn't aware that HTML accepts all attributes. In the revised one it is prefixed with "pandoc-" to mark it as an internal one (and simply ignored in HTML). |
656df95 to
28800b7
Compare
Adds an optional argument ('pandoc-pos') to position figures
(with or without captions).
Supported positions: here (floating), top (default), bottom,
page (single page figure).
ODT Parser translates the positions of the figures (frames) in
the following way:
'as-char' -> 'here'
'page' -> 'page
Those image attributes are then translated in the appropriate
element in the output document, if supported.
Currently only Latex interprets such image attributes (with the
appropriate argument to the figure environment) but
other writers (and readers) can easily support it as well.
Since HTML takes whatever attributes were parsed, we have to filter
out the internal 'pandoc-' ones.
Added some explicit type annotations to help with older GHC versions.
28800b7 to
4da97fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to position figures with captions.
Currently only ODT parses its position information but
other inputs formats can easily support it as well.