10000 feat: Add description for tf executor example by jacobowitz · Pull Request #2484 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add description for tf executor example #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021

Conversation

jacobowitz
Copy link
Contributor

This adds a small description to the Tensorflow Executor in the cookbook. One could add potentially how that can or should not be used in a search context, but I think its a bit too much detail at this point.

@jacobowitz jacobowitz requested a review from a team as a code owner May 26, 2021 07:58
@jacobowitz jacobowitz requested review from CatStark and Kelton8Z May 26, 2021 07:58
@jacobowitz jacobowitz requested review from hanxiao and JoanFM and removed request for Kelton8Z May 26, 2021 07:58
@jina-bot jina-bot added the area/housekeeping This issue/PR is housekeeping label May 26, 2021
@jacobowitz jacobowitz force-pushed the feat-tf-executor-example-doc branch from a19c5f6 to 3aa33c1 Compare May 26, 2021 08:33
@codecov
Copy link
codecov bot commented May 26, 2021

Codecov Report

Merging #2484 (b03f4bc) into master (c4a9318) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
+ Coverage   83.34%   83.41%   +0.07%     
==========================================
  Files         152      152              
  Lines        9425     9425              
==========================================
+ Hits         7855     7862       +7     
+ Misses       1570     1563       -7     
Flag Coverage Δ
daemon 47.03% <ø> (ø)
jina 83.23% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/compound.py 91.53% <0.00%> (+1.53%) ⬆️
jina/peapods/peas/__init__.py 96.72% <0.00%> (+2.45%) ⬆️
jina/peapods/runtimes/asyncio/grpc/async_call.py 98.11% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413b6c8...b03f4bc. Read the comment docs.

davidbp
davidbp previously approved these changes May 26, 2021
Copy link
Contributor
@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobowitz jacobowitz merged commit 8a5701b into master May 26, 2021
@jacobowitz jacobowitz deleted the feat-tf-executor-example-doc branch May 26, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0