8000 fix: small fix attr by JoanFM · Pull Request #2559 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: small fix attr #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix: small fix attr #2559

merged 1 commit into from
Jun 4, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 4, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 4, 2021 08:35
@JoanFM JoanFM requested review from nan-wang and alanthssss June 4, 2021 08:35
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jun 4, 2021
@codecov
Copy link
codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #2559 (e7cafe3) into master (f6319e7) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
+ Coverage   85.97%   86.14%   +0.16%     
==========================================
  Files         152      152              
  Lines        9503     9503              
==========================================
+ Hits         8170     8186      +16     
+ Misses       1333     1317      -16
Flag Coverage Δ
daemon 46.63% <0.00%> (ø)
jina 86.13% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/compound.py 89.47% <100.00%> (+7.51%) ⬆️
jina/flow/base.py 90.59% <0.00%> (+0.91%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.80% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065c98a...e7cafe3. Read the comment docs.

@JoanFM JoanFM merged commit 6363bb2 into master Jun 4, 2021
@JoanFM JoanFM deleted the small-fix branch June 4, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@alanthssss alanthssss Awaiting requested review from alanthssss

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @jacobowitz @jina-bot
0