8000 refactor: remove unused code by JoanFM · Pull Request #2600 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove unused code #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

refactor: remove unused code #2600

merged 1 commit into from
Jun 9, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 9, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 9, 2021 13:41
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase labels Jun 9, 2021
@JoanFM JoanFM force-pushed the parse-remove-unused branch from 0ce8ffd to bc54991 Compare June 9, 2021 14:32
@codecov
Copy link
codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #2600 (e1e5584) into master (aa927e4) will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
+ Coverage   86.87%   87.42%   +0.55%     
==========================================
  Files         154      153       -1     
  Lines        9638     9602      -36     
==========================================
+ Hits         8373     8395      +22     
+ Misses       1265     1207      -58
Flag Coverage Δ
daemon 46.57% <ø> (+0.14%) ⬆️
jina 87.50% <ø> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/__init__.py 100.00% <ø> (ø)
jina/parsers/helper.py 45.52% <ø> (+3.13%) ⬆️
jina/parsers/hub/__init__.py 100.00% <ø> (+22.50%) ⬆️
jina/helper.py 78.52% <0.00%> (-0.39%) ⬇️
jina/flow/base.py 90.68% <0.00%> (+0.90%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.80% <0.00%> (+0.95%) ⬆️
jina/peapods/peas/__init__.py 96.77% <0.00%> (+2.41%) ⬆️
jina/peapods/pods/__init__.py 90.03% <0.00%> (+4.53%) ⬆️
jina/peapods/pods/compound.py 90.97% <0.00%> (+9.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa927e4...e1e5584. Read the comment docs.

@JoanFM JoanFM force-pushed the parse-remove-unused branch from bc54991 to e1e5584 Compare June 9, 2021 14:50
@jina-bot jina-bot added the area/cli This issue/PR affects the command line interface label Jun 9, 2021
bwanglzu
bwanglzu approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoanFM JoanFM merged commit 0b41d08 into master Jun 9, 2021
@JoanFM JoanFM deleted the parse-remove-unused branch June 9, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @bwanglzu @jina-bot
0