8000 refactor: remove legacy plugin dependencies by hanxiao · Pull Request #2635 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove legacy plugin dependencies #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2021
Merged

refactor: remove legacy plugin dependencies #2635

merged 5 commits into from
Jun 13, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 13, 2021

No description provided.

@jina-bot jina-bot added size/S area/setup This issue/PR affects setting up Jina labels Jun 13, 2021
@jina-bot jina-bot added area/core This issue/PR affects the core codebase component/resource labels Jun 13, 2021
@codecov
Copy link
codecov bot commented Jun 13, 2021 •
edited
Loading

Codecov Report

Merging #2635 (538812f) into master (0094bbf) will increase coverage by 6.37%.
The diff coverage is 83.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2635      +/-   ##
==========================================
+ Coverage   82.21%   88.59%   +6.37%     
==========================================
  Files         106      148      +42     
  Lines        7064     8947    +1883     
==========================================
+ Hits         5808     7927    +2119     
+ Misses       1256     1020     -236
Flag Coverage Δ
daemon 48.38% <83.11%> (?)
jina 88.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.76% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 89.47% <ø> (ø)
jina/clients/asyncio.py 100.00% <ø> (ø)
jina/clients/base.py 79.20% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/mixin.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 100.00% <ø> (ø)
jina/clients/request/asyncio.py 88.88% <ø> (ø)
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63498a7...538812f. Read the comment docs.

@hanxiao hanxiao requested a review from a team as a code owner June 13, 2021 08:17
@hanxiao hanxiao requested review from mapleeit and cristianmtr June 13, 2021 08:17
@jina-bot jina-bot added area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing labels Jun 13, 2021
@hanxiao hanxiao merged commit 75bea98 into master Jun 13, 2021
@hanxiao hanxiao deleted the refactor-extra-deps branch June 13, 2021 08:54
numb3r3 pushed a commit that referenced this pull request Jun 15, 2021
@hanxiao @numb3r3
refactor: remove legacy plugin dependencies (#2635)
d52cdfc 
* refactor: remove legacy plugin dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit Awaiting requested review from mapleeit

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0