refactor: remove unused setters in graph document #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
+ Coverage 82.21% 88.65% +6.43%
==========================================
Files 106 147 +41
Lines 7064 8945 +1881
==========================================
+ Hits 5808 7930 +2122
+ Misses 1256 1015 -241
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we exposed too much setter to the user, such as
edge_featuresandadjacency, user can set the value for these properties, but the internal graph structure did not change.For instance, change
edge_featuresin a setter, whilenode.idremains the same. We expect the key ofedge_featuresshould benode1.id-node2.id, this brings inconsistency. Same applies foradjacency.btw, there're two setters for
adjacency..