8000 refactor: remove ssh and zmqmany runtimes by JoanFM · Pull Request #2698 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove ssh and zmqmany runtimes #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 18, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 18, 2021 09:18
@JoanFM JoanFM requested review from mapleeit and jakobkruse1 June 18, 2021 09:18
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Jun 18, 2021
@codecov
Copy link
codecov bot commented Jun 18, 2021

Codecov Report

Merging #2698 (08bbbf2) into master (7dfdfd0) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
+ Coverage   89.50%   89.59%   +0.09%     
==========================================
  Files         148      147       -1     
  Lines        9164     9101      -63     
==========================================
- Hits         8202     8154      -48     
+ Misses        962      947      -15     
Flag Coverage Δ
daemon 47.55% <ø> (+0.10%) ⬆️
jina 89.83% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/__init__.py 78.57% <ø> (-1.43%) ⬇️
jina/peapods/runtimes/zmq/base.py 100.00% <ø> (+19.64%) ⬆️
jina/clients/base.py 79.00% <0.00%> (-3.00%) ⬇️
jina/peapods/zmq/__init__.py 83.13% <0.00%> (-2.08%) ⬇️
jina/helper.py 82.11% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfdfd0...08bbbf2. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 18, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1354, delta to last 1 avg.: +0%
  • 🐢🐢 query QPS at 41, delta to last 1 avg.: -12%

Breakdown

Version Index QPS Query QPS
current 1354 41
2.0.0rc6 1342 46

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Jun 18, 2021
@JoanFM JoanFM reopened this Jun 18, 2021
@JoanFM JoanFM requested review from bwanglzu and deepankarm June 18, 2021 10:15
@JoanFM JoanFM merged commit d07da38 into master Jun 18, 2021
@JoanFM JoanFM deleted the remove-zmqmany-runtime branch June 18, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0