8000 test: complete craft and encode tests in hello multimodal by bwanglzu · Pull Request #2704 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: complete craft and encode tests in hello multimodal #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

bwanglzu
Copy link
Member
@bwanglzu bwanglzu commented Jun 19, 2021

┆Issue is synchronized with this Asana task by Unito

8000 @bwanglzu bwanglzu requested a review from a team as a code owner June 19, 2021 10:50
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jun 19, 2021
@codecov
Copy link
codecov bot commented Jun 19, 2021

Codecov Report

Merging #2704 (97a3e57) into master (0094bbf) will increase coverage by 7.39%.
The diff coverage is 83.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
+ Coverage   82.21%   89.61%   +7.39%     
==========================================
  Files         106      147      +41     
  Lines        7064     9101    +2037     
==========================================
+ Hits         5808     8156    +2348     
+ Misses       1256      945     -311     
Flag Coverage Δ
daemon 47.55% <83.11%> (?)
jina 89.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.21% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 89.47% <ø> (ø)
jina/clients/asyncio.py 100.00% <ø> (ø)
jina/clients/base.py 79.00% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/mixin.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 100.00% <ø> (ø)
jina/clients/request/asyncio.py 88.88% <ø> (ø)
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1ecdf...97a3e57. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 19, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1629, delta to last 1 avg.: +1%
  • 🐢🐢 query QPS at 64, delta to last 1 avg.: -10%

Breakdown

Version Index QPS Query QPS
current 1629 64
2.0.0rc6 1610 71

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 5af912d into master Jun 21, 2021
@JoanFM JoanFM deleted the test-complete-multimodal branch June 21, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0