8000 fix: change alias to pea by JoanFM · Pull Request #2719 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: change alias to pea #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2021
Merged

fix: change alias to pea #2719

merged 2 commits into from
Jun 22, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 21, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@JoanFM JoanFM requested a review from a team as a code owner June 21, 2021 12:18
@jina-bot jina-bot added size/XS area/cli This issue/PR affects the command line interface labels Jun 21, 2021
@codecov
Copy link
codecov bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #2719 (42bc789) into master (c459dcd) will increase coverage by 1.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
+ Coverage   87.99%   89.49%   +1.49%     
==========================================
  Files         152      152              
  Lines        9358     9358              
==========================================
+ Hits         8235     8375     +140     
+ Misses       1123      983     -140
Flag Coverage Δ
daemon 48.18% <ø> (ø)
jina 89.74% <ø> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (ø)
jina/types/message/__init__.py 89.16% <0.00%> (+0.98%) ⬆️
jina/peapods/zmq/__init__.py 85.35% <0.00%> (+2.02%) ⬆️
jina/peapods/pods/compound.py 89.62% <0.00%> (+2.96%) ⬆️
jina/helper.py 81.70% <0.00%> (+3.25%) ⬆️
jina/peapods/pods/__init__.py 84.27% <0.00%> (+3.77%) ⬆️
jina/peapods/runtimes/asyncio/http/models.py 100.00% <0.00%> (+4.71%) ⬆️
jina/peapods/peas/helper.py 97.43% <0.00%> (+5.12%) ⬆️
jina/peapods/networking.py 94.73% <0.00%> (+5.26%) ⬆️
jina/peapods/peas/__init__.py 93.79% <0.00%> (+9.65%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c459dcd...42bc789. Read the comment docs.

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Jun 21, 2021
8000
nan-wang
nan-wang approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@JoanFM JoanFM marked this pull request as draft June 22, 2021 04:39
@JoanFM
Copy link
Contributor Author
JoanFM commented Jun 22, 2021

LGTM👍

Lets discuss definitely on slack if we really want this

@JoanFM JoanFM marked this pull request as ready for review June 22, 2021 05:52
@JoanFM JoanFM merged commit fba59ae into master Jun 22, 2021
@JoanFM JoanFM deleted the fix-alias branch June 22, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @nan-wang @jina-bot @maximilianwerk
0