8000 fix: make second RTCPeerConnection constructor parameter optional (#32) by athouary · Pull Request #33 · jitsi/rtcstats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make second RTCPeerConnection constructor parameter optional (#32) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: make second RTCPeerConnection constructor parameter optional (#32) #33

merged 1 commit into from
Nov 14, 2023

Conversation

athouary
Copy link

No description provided.

@athouary athouary mentioned this pull request Oct 23, 2023
Merged
@saghul
Copy link
Member
saghul commented Oct 23, 2023

@andrei-gavrilescu can you PTAL?

andrei-gavrilescu
andrei-gavrilescu reviewed Oct 24, 2023
View reviewed changes
@andrei-gavrilescu
Copy link

Is this change required in the associated ljm PR? if so then rtcstats would need to be updated there as well.

@athouary
Copy link
Author
athouary commented Nov 2, 2023

This change is not directly related to the mentioned ljm PR. However, rtcstats does need to be updated there. Should I open a PR for that in ljm?

@andrei-gavrilescu
Copy link

This change is not directly related to the mentioned ljm PR. However, rtcstats does need to be updated there. Should I open a PR for that in ljm?

Got it, I'll make npm release of rtcstats after this gets merged. I'll ping you with the new version.
Afterwards if you're willing to bump the version in ljm that'd be great, if you don't have the time I can just bump it later on.

@andrei-gavrilescu andrei-gavrilescu merged commit 662cda0 into jitsi:master Nov 14, 2023
@athouary athouary deleted the 37-fix-rtcpeerconnection-constructor-signature branch November 14, 2023 11:13
@athouary
Copy link
Author

@andrei-gavrilescu Just a little reminder about making an npm release. I'll take care of bumping the version in ljm.

Thanks!

@andrei-gavrilescu
Copy link

@andrei-gavrilescu Just a little reminder about making an npm release. I'll take care of bumping the version in ljm.

Thanks!

Thanks for the reminder, v9.7.0 has been published to npm.

86CF

@mak1e mak1e mentioned this pull request Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-gavrilescu andrei-gavrilescu Awaiting requested review from andrei-gavrilescu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@athouary @saghul @andrei-gavrilescu
0