Dev #31
Merged
Dev #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library will no longer be supported. A similar library will replace it that is based on .NET Standard using HidSharp for the core USB communications interface. This offers cross-platform support.
Cross-platform, open-source.
Updated project files for .NET 8.
Serial numbers are now tab completed in the CLI via the VIConCompletion.psm1 module.
With the new libdp100, preset-0 now works as expected. UI interaction with this preset is now enabled.
When the DP100 has no input supply, the progress bar logic would produce an exception due to progress == NaN.
Added additional note about current behavior of OVP/OCP. However, these parameter behaviors should be changed. It is desirable to only modify the specified argument value and not apply other values to the preset. This likely means a "--write-pre" option should be introduced to perform a full write.
NOTE: it might be a good idea to constrain ranges. This might be best to do in the PSU DLL.
Removed a questionable call to ExitAlternateScreenBuffer(). This may have been introduced previously for other reasons which have since been removed/abandoned. This call was causing undesired behavior in the CLI.
With the updated libdp100 StopWorkerThread() will not return until the thread stops.
Switch to native .NET JSON serialization.
With the switch to .NET 9, there are various warnings that should be resolved in the application. Other minor recommendations also applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update
Migrated to .NET Core.
Replaced ATK-DP100.DLL with custom USB HID library based on cross-platform HidSharp (.NET Standard 2.0).
Switched to native C# JSON library.
Improved library documentation (more required at application level)