Change cgltf_accessor_unpack_indices to work with int vectors
#267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces 3 improvements to the `cgltf_accessor_unpack_indices` function: 1. Query `cgltf_num_components` and use it to load int vectors properly - this is useful for loading vec4 uint8_t joint indices. 2. Add support for uint8_t in slow path (for loop) in cases where data wasn't tightly packed (previously the function wouldn't do anything). 3. Return 0 on failure instead of failing silently and leaving memory uninitialized.
|
This brings this function closer to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 3 improvements to the
cgltf_accessor_unpack_indicesfunction:cgltf_num_componentsand use it to load int vectors properly - this is useful for loading vec4 uint8_t joint indices.