8000 Handle fields with `null` value by domachine · Pull Request #98 · jo/couchdb-compile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle fields with null value #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

domachine
Copy link
Contributor

Hello and thank you for your valueable work,

I just ran into a problem with a document that includes a field with a null value. Digging a little deeper it seems that the objToJson function currently doesn't handle fields with a null value correctly. This PR includes a test that seems to reproduce this problem. Is this a bug or do I misunderstand the usage?

Regards!

@jo jo merged commit 226e639 into jo:main Oct 14, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jo
Copy link
Owner
jo commented Oct 14, 2021

Oh @domachine thank you so much and sorry for my late response

@domachine domachine deleted the fix/null-fields branch October 15, 2021 08:13
@domachine
Copy link
Contributor Author

Oh @domachine thank you so much and sorry for my late response

Thank you for including this change 🎉! Don't worry. I really appreciate your valuable work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0