import garmin data in date range #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Garmin integration to support date-range-based data retrieval by updating both backend endpoints and frontend UI components while also improving error logging.
- The backend now uses start_date and end_date parameters instead of days to fetch activities and health data.
- The frontend updates include new modal components as well as revised translation strings for date range selection.
- API routes, service calls, and utility functions have been adjusted to handle the new date range parameters.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/app/src/services/garminConnectService.js | Updated service methods for activities and health data to use date range parameters. |
| frontend/app/src/i18n/* | Updated labels and modal titles in multiple languages to reflect date range usage. |
| frontend/app/src/components/Settings/SettingsIntegrationsZone.vue | Modified modal calls and component imports to use date range modals. |
| frontend/app/src/components/Modals/ModalComponentDateRangeInput.vue | New modal component for date range input. |
| backend/app/garmin/router.py | Updated endpoints and parameter processing to use date range values. |
| backend/app/garmin/health_utils.py & activity_utils.py | Refactored functions to process data using start_date and end_date parameters. |
|
Hello. This is merged on pre-release. I'll ask you next time to not remove functionality, or at least ask before removing to ensure consistency. :) |
|
Hey sorry for the removal, will be more careful next time 🙇♂️ |
|
No worries. Thanks again for the help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the Garmin integration, transitioning from "days-based" to "date-range-based" functionality for activity and health data retrieval. It includes backend updates to support date ranges, frontend modifications for user input, and improved error handling and logging.
Backend Changes
Refactored Functions to Support Date Ranges:
fetch_and_process_activities_by_datesandfetch_and_process_bc_by_dates: Updated to acceptstart_dateandend_dateparameters instead of calculating based on days. These functions now fetch data within a specific date range, improving flexibility. [1] [2]get_user_garminconnect_activities_by_datesandget_user_garminconnect_bc_by_dates: Replaced the previous "days-based" functions to handle date ranges. Added detailed logging for the date range being processed. [1] [2]Enhanced Error Handling and Logging:
Frontend Changes
New Date Range Modal Component:
ModalComponentDateRangeInput.vue: A reusable modal for selecting start and end dates, with default values pre-set to the last 7 days. This component emits the selected date range for further processing.Updated UI for Garmin Data Retrieval:
SettingsIntegrationsZone.vueto replace "days-based" options with "date-range-based" options for both activity and health data retrieval.API Changes
/activitiesand/healthendpoints to acceptstart_dateandend_dateparameters instead ofdays. Adjusted background tasks to use the new date range methods. [1] [2]