Read ENDURAIN_HOST from config.json #214
Conversation
|
Ok, I understand. :) With that in mind, what do you recommend in order to keep this easier for these use cases? EDIT: New volume, for example?
|
|
I didn't think it was very difficult to set up, but there were some parts that could be smoothed out. There are a lot of file mounts currently. Maybe you could have a generic "data" directory that includes all those subdirectories by default. I've seen many containers that just make this In kubernetes I mount the config.json from a configmap, so mounting it as a volume in docker would make a lot of sense as well. If you want to make it easier for the average user that doesn't care as much about immutability then the start.sh script could check for the config.json and create it from an environment variable if its missing. |
|
Yes, the issue with the multiple volumes mount will be fixed in v0.13.0 :) And sorry for not pushing to this PR |
|
That's a very clean approach. I like it. |
|
Implemented on v0.12.4 |
Addresses #213
This adds a config.json in the frontend/app/public dir which can store non-sensitive runtime configuration without the need for sed. I've used this approach several times in other applications, though not in Vue so the implementation may not be idiomatic.