8000 Add namespace to chart, support for custom namespace by kruchkov-alexandr · Pull Request #180 · joe-elliott/cert-exporter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add namespace to chart, support for custom namespace #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add namespace to chart, support for custom namespace #180

wants to merge 2 commits into from

Conversation

kruchkov-alexandr
Copy link

Summary of Changes

  • Namespace Support: Added namespace field to cert-manager.yaml, service.yaml, and values.yaml with a default value of monitoring.
  • Tag Update: Made the tag field in values.yaml customizable, defaulting to .Chart.AppVersion.

These changes enhance flexibility for namespace configuration and image tag management.

Local tests for another namespace:

helm upgrade \
  --install cert-exporter helm/cert-exporter/ \
  --set certManager.namespace=service \
  --set dashboards.namespace=service \
  --values helm/cert-exporter/values.yaml

@kruchkov-alexandr
Copy link
Author

@joe-elliott hey
please take a look at this pull request. Thanks!

@joe-elliott
Copy link
Owner

howdy! thanks for the PR. i've been meaning to get to this.

i think my only question is: will this impact folks who have installed cert-exporter in namespaces besides "monitoring" when they go to upgrade?

@kruchkov-alexandr
Copy link
Author

It shouldn't be an issue at all, as far as I understand.
That's exactly why I created the pull request so you could review it =)

@joe-elliott
Copy link
Owner

I just don't really know much about helm and this chart is basically community maintained. I do value not changing things unnecessarily if its basically working for folks. If this is a valuable improvement I'll merge it, but I need to know it won't negatively impact people currently using the chart.

@joe-elliott joe-elliott mentioned this pull request Mar 7, 2025
Open
@CarstenSon
Copy link
Contributor
CarstenSon commented May 6, 2025 •
edited
Loading

hey @kruchkov-alexandr 😄

Would you mind making the namespace optional (e.g. using if/with) in the helm-chart? Since it's not a required field in the underlying k8s spec that would make it a non-breaking change for folks who don't have the namespace set currently. I often work with Bearer tokens that are only entitled for certain namespaces and like the minimal approach of the current helmchart.

If this was optional my setup wouldn't be concerned/affected at all - with the current implementation it would be a breaking change as I'd need to set the namespace for each deployment of cert-exporter :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruchkov-alexandr @joe-elliott @CarstenSon
0