package changes to support node19 #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the linting workflow step failed due to some issue with the github workflow itself. it was not picking up the latest workflow code. I had modified the workflow code because it was not picking up the branch before loading the dependencies. The new dependencies needed the new package.json for linting. |
lorensr
reviewed
Jun 24, 2023
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| #### Updated | |||
| - [#495](https://github.com/join-monster/join-monster/pull/495): Added support for GraphQL v16_6_0. There were a number of breaking changes introduced in GraphQL v16 and these impacted a large number of tests and bit of the code. This provides fixes for those breaking changes. It also drops support for Node versions 10 - 13 but adds support for Node v16. | |||
| - - [496](https://github.com/join-monster/join-monster/pull/496): Adding support for Node v17 - v19. | |||
| @@ -34,8 +34,8 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | |||
| # node-version: [10.x, 12.x, 13.x, 14.x, 15.x] | |||
| node-version: [14.x, 15.x, 16.x] | |||
| # covering 14, 16, 17 then 18 and 19. assuming 15 will work otherwise | |||
There was a problem hiding this comment.
not sure what "otherwise" means here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Currently join-monster only supports some earlier versions of node 14x - 16x. The sqllite3 install fails for node 17-19.
This PR is meant to add those additional versions of node.
References
Testing
Checklist