8000 [CI]: fix docker images versions by nicoabie · Pull Request #520 · join-monster/join-monster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CI]: fix docker images versions #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on 8000 GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2024
Merged

[CI]: fix docker images versions #520

merged 3 commits into from
May 3, 2024

Conversation

nicoabie
Copy link
Contributor
@nicoabie nicoabie commented May 2, 2024 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fixed versions of mysql, postgres and adminer in dockerfile.
Test against even node versions.
Deprecate node 14.x

References

Include any links supporting this change such as a:

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR via comments and by updating the change log

@nicoabie nicoabie self-assigned this May 2, 2024
@nicoabie nicoabie force-pushed the fix/issue-515 branch 21 times, most recently from 8f28964 to 481f1ec Compare May 3, 2024 16:14
@nicoabie nicoabie changed the title [CI]: fix issue waiting for docker to be in a healthy state [CI]: fix docker images versions May 3, 2024
@nicoabie nicoabie merged commit 9232f24 into master May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicoabie nicoabie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test flake on database startup
1 participant
@nicoabie
0