8000 Remove the dispatch event functions in model and view by laoneo · Pull Request #458 · joomla/Manual · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove the dispatch event functions in model and view #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove the dispatch event functions in model and view #458

wants to merge 5 commits into from

Conversation

laoneo
Copy link
Member
@laoneo laoneo commented May 5, 2025 •
edited by qodo-merge-pro bot
Loading

User description

joomla/joomla-cms#45431

PR Type

documentation

Description

  • Document removal of dispatchEvent proxy functions in model and view.

  • Provide migration guidance for using dispatcher directly.

  • Specify affected files and updated usage example.

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document removal of dispatchEvent proxy functions               

migrations/54-60/removed-backward-incompatibility.md

  • Added section on removal of dispatchEvent proxy functions.
  • Listed affected files and described migration path.
  • Included code example for updated event dispatching.
    		• +16/-0   
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @laoneo laoneo mentioned this pull request May 5, 2025
    Open
    4 tasks
    @HLeithner HLeithner added 6.0 PR for Joomla 6.0 Waiting for Joomla reference PR This pr is ready to merge and can be merged when the corresponding Joomla cms pr is merged. labels May 5, 2025
    @laoneo laoneo closed this May 26, 2025
    @laoneo laoneo deleted the remove/dispatcher branch May 26, 2025 15:28
    @rdeutz rdeutz restored the remove/dispatcher branch May 28, 2025 16:13
    @rdeutz rdeutz reopened this May 28, 2025
    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Grammar Issue

    The sentence explaining the getDispatcher function contains a grammatical error that may confuse readers trying to migrate their code.

     
    - Description: The `dispatchEvent` proxy functions are removed in the `BaseDatabaseModel` and `AbstractView` classes. The `getDispatcher` function therefor requires no a dispatcher injected, which is the default, when the component is booted through the application.

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor
    qodo-merge-pro bot commented May 28, 2025 •
    edited
    Loading

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    richard67
    richard67 reviewed Jun 2, 2025
    View reviewed changes
    laoneo and others added 2 commits June 2, 2025 17:18
    richard67
    richard67 reviewed Jun 2, 2025
    View reviewed changes
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @richard67 richard67 richard67 left review comments

    Assignees
    No one assigned
    Labels
    6.0 PR for Joomla 6.0 Review effort 1/5 Waiting for Joomla reference PR This pr is ready to merge and can be merged when the corresponding Joomla cms pr is merged.
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    3B27
    4 participants
    @laoneo @richard67 @rdeutz @HLeithner
    0