8000 Update compatibility plugin by HLeithner · Pull Request #461 · joomla/Manual · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update compatibility plugin #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update compatibility plugin #461

wants to merge 2 commits into from

Conversation

HLeithner
Copy link
Member
@HLeithner HLeithner commented May 6, 2025 •
edited by qodo-merge-pro bot
Loading

PR Type

Documentation

Description

  • Refactored and clarified documentation for Compatibility Plugin.

  • Improved developer warnings and notes formatting.

  • Updated and corrected links to related migration documentation.

  • Added details about Joomla 6 Compatibility Plugin in relevant files.

Changes walkthrough 📝

Relevant files
Documentation
compat-plugin.md
Refactor and clarify Joomla 5 Compatibility Plugin documentation

migrations/50-51/compat-plugin.md

  • Changed heading formatting for clarity.
  • Added explicit section for Joomla 5 Compatibility Plugin.
  • Replaced inline warning with formatted developer note.
  • Updated link to use relative path for consistency.
    		• +9/-3     
    compat-plugin.md
    Improve structure and warnings in compatibility plugin doc

    migrations/51-52/compat-plugin.md

  • Updated heading and section formatting.
  • Added developer note with warning formatting.
  • Changed link to use relative path.
    		• +9/-3     
    compat-plugin.md
    Enhance formatting and developer notes in documentation   

    migrations/52-53/compat-plugin.md

  • Improved heading and section formatting.
  • Added formatted developer warning note.
  • Updated documentation link to relative path.
    		• +9/-3     
    compat-plugin.md
    Add Joomla 6 plugin info and improve warnings                       

    migrations/53-54/compat-plugin.md

  • Moved and reformatted developer warning note.
  • Updated documentation link to relative path.
  • Added section for Joomla 6 Compatibility Plugin.
    		• +7/-4     
    compat-plugin.md
    Refactor, clarify, and expand compatibility plugin documentation

    migrations/54-60/compat-plugin.md

  • Refactored headings and added warning note for developers.
  • Clarified Joomla 5 and 6 plugin details.
  • Updated and added links to related documentation.
  • Introduced section for Joomla 6 Compatibility Plugin.
    		• +16/-6   
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor
    qodo-merge-pro bot commented May 6, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor
    qodo-merge-pro bot commented May 6, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    ✅ Clarify plugin type usage

    The text contradicts the warning about not creating plugins as behaviour type.
    Clarify whether the new Joomla 6 plugin uses the behaviour type despite the
    warning, or if it uses a different approach.

    migrations/54-60/compat-plugin.md [25-28]

     In Joomla! 6.0 the Compatibility Plugin introduced in Joomla! 5.0 will be replaced by a new plugin
 called "Behaviour - Backward Compatibility 6".
 
-The plugin is implemented as "Behaviour" plugin type to guarantee that is loaded before any other plugin is loaded.
+Despite the warning about the potential removal of the `behaviour` plugin type, this compatibility plugin still uses this type to ensure it loads before any other plugin, as this is critical for backward compatibility functionality.

    [Suggestion has been applied]

    Suggestion importance[1-10]: 6

    __

    Why: The suggestion correctly identifies a potential point of confusion regarding the behaviour plugin type and proposes a clarification. The improved_code accurately adds this explanation, enhancing the document's clarity.

    		Low
    • Update

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qodo-merge-pro qodo-merge-pro[bot] qodo-merge-pro[bot] left review comments

    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @HLeithner
    0