8000 Fix for fetch queries that use entity name in condition by BetimBeja · Pull Request #411 · jordimontana82/fake-xrm-easy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 16, 2024. It is now read-only.

Fix for fetch queries that use entity name in condition #411

Merged
merged 5 commits into from
Jul 29, 2019

Conversation

BetimBeja
Copy link
Contributor

Hello @jordimontana82 ,
this PR fixes #284. There are some cases that could be checked that I haven't implemented where the service should throw an exception like for example when the entity name is ambiguous because there are two link entities to the same entity, etc.

Best regards,
Betim.

@BetimBeja
Copy link
Contributor Author

Hello @jordimontana82,
Can you please review the PRs, I added the missing validations from the first commit too.
Best regards,
Betim.

@BetimBeja
Copy link
Contributor Author

Hello @jordimontana82 ,
I improved this PR by fixing issue #391 too.
Can you please review and merge this one as I had the need to write a test which had nested filters and entity name in condition just today and we just left the test commented. 😞

Best regards,
Betim.

@jordimontana82
Copy link
Owner

Thx a mill @BetimBeja I'll take a look...

@jordimontana82 jordimontana82 merged commit 2265065 into jordimontana82:master Jul 29, 2019
@BetimBeja BetimBeja deleted the AttributeEntityName branch July 30, 2019 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Fetch queries that use entityname in condition
2 participants
0