8000 fix errors when running ./tests/custom/run_tests.sh on Macos by ErwanMAS · Pull Request #176 · jow-/ucode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix errors when running ./tests/custom/run_tests.sh on Macos #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix errors when running ./tests/custom/run_tests.sh on Macos #176

wants to merge 2 commits into from

Conversation

ErwanMAS
Copy link
@ErwanMAS ErwanMAS commented Oct 19, 2023 •
edited
Loading
  • set LC_ALL=C
  • generate the tempdir differently so this working on Macos ( still working on linux )
  • keep the tempdir when we have a failure
  • fix difference on uc_index because of difference of implementation of memmem between Linux/MacOs
  • add a regeression test for readlink

@ErwanMAS ErwanMAS changed the title reduce errors when building on Macos fix errors when running ./tests/custom/run_tests.sh on Macos Oct 20, 2023
@ErwanMAS ErwanMAS force-pushed the improve_test_on_macos branch from 7f9e809 to 7193cf5 Compare October 20, 2023 15:58
@ErwanMAS
Copy link
Author

Hi @nbd168 ,
I saw you committed some changes related to MacOs , do you have times to test this PR ?
I tested this PR on MacoS Ventura .

jow- added a commit that referenced this pull request Nov 1, 2023
@jow-
lib: enforce consistent index() behavior with empty needle argument
448c763 
On macOS, the `memmem()` function returns `NULL` instead of the expected
start of the haystack string when given a zero-length needle argument.

Add special case handling for a zero-length needle argument to ensure
that the expected offset `0` is returned on all systems.

Ref: #176
Suggested-by: Erwan MAS <erwan@mas.nom.fr>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@ErwanMAS ErwanMAS force-pushed the improve_test_on_macos branch from c68d63a to 464ed1a Compare November 4, 2023 22:00
@ErwanMAS
small changes to be able to run test on MacOs
7472bb1 
set LC_ALL=C to avoid utf8 warning on macos
generate the tempdir differently so this working on Macos ( still working on linux )
keep the tempdir when we have a failure
add a regeression test for readlink
@ErwanMAS ErwanMAS force-pushed the improve_test_on_macos branch from 464ed1a to 7472bb1 Compare November 4, 2023 22:04
@ErwanMAS
Copy link
Author
ErwanMAS commented Nov 4, 2023

@jow- , i updated this PR because i saw you fixed the issue with memmem .

I tested this on Macos 13.6 and on Debian Bookwork . On both systems /tests/custom/run_tests.sh
return the same status and a clean output
Ran 170 tests, 170 okay, 0 failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ErwanMAS
0