Replace regex with parser #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a fragile regex-based approach for parsing component tags with a dedicated parser to prevent misinterpretation of embedded characters and syntax errors.
- Introduces comprehensive test cases for both valid and invalid component tags.
- Refactors JinjaX methods to use new functions (replace_raw_blocks, process_tags, restore_raw_blocks) and a new parser for opening tags.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_extension.py | Added extensive test cases covering different component tag scenarios including nested and invalid cases. |
| src/jinjax/jinjax.py | Replaces regex parsing with a new parser implementation and refactors private methods to public ones with updated naming. |
Comments suppressed due to low confidence (1)
src/jinjax/jinjax.py:129
- The variable name 'max' shadows the built-in function 'max'. Consider renaming it (for example, 'source_length') for better clarity and to avoid potential issues.
max = len(source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My quick-and-dirty regex for parsing component tags finally backfired when I tried to add a Stimulus action
... and JinjaX treated the
>inclick->as the closing tag. 🤦♂️So I had to write a real parser. While adding tests, I found the old code also allowed syntax errors like unmatched quotes or braces. The new parser fixes all that so is another win 👍.