Use internal import when possible
#443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The swiftlint issue around imports is a false positive (it can't handle the #if) and can be worked around, but I think the Windows failures are something worth looking into. All the recent open PRs are suffering from it. |
lynchsft
approved these changes
Apr 11, 2025
|
@pennig The windows failures are now resolved in the main branch. Please merge/rebase. :) |
|
@lynchsft all set! |
|
The test pass! 🎉 Thank you. :) @pennig can you resolve the lint error? As soon as that's clear, I'll merge and prepare a new release soon with this and a few other fixes. |
|
@lynchsft One more go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses warnings around
@_implementationOnly importstatements when compiled with Xcode 16.3 / Swift 6.1