jraska · jraska · Apr 30, 2021 · Apr 30, 2021 · Apr 30, 2021 · Apr 30, 2021
diff --git a/app/build.gradle b/app/build.gradle
@@ -86,6 +86,10 @@ android {
       srcDirs += ["../feature/about/src/androidTest/java"]
       srcDirs += ["../feature/users/src/androidTest/java"]
     }
+    sourceSets.androidTest.assets {
+      srcDirs += ["../feature/about/src/androidTest/assets"]
+      srcDirs += ["../feature/users/src/androidTest/assets"]
+    }
   }
 }
 
@@ -157,10 +161,12 @@ dependencies {
   androidTestImplementation 'com.airbnb.okreplay:espresso:1.6.0'
   androidTestImplementation 'com.squareup.rx.idler:rx3-idler:0.11.0'
   androidTestImplementation project(':core-testing')
+  androidTestImplementation project(':core-android-testing')
 
   androidTestImplementation rootProject.ext.retrofit
   androidTestImplementation rootProject.ext.retrofitGsonConverter
   androidTestImplementation rootProject.ext.retrofitRxJavaAdapter
+  androidTestImplementation okHttpMockWebServer
 
   kaptAndroidTest rootProject.ext.daggerAnnotationProcessor
 }

diff --git a/app/src/androidTest/java/com/jraska/github/client/TestUITestApp.kt b/app/src/androidTest/java/com/jraska/github/client/TestUITestApp.kt
@@ -5,6 +5,8 @@ import androidx.test.platform.app.InstrumentationRegistry
 import com.jraska.github.client.core.android.BaseApp
 import com.jraska.github.client.core.android.ServiceModel
 import com.jraska.github.client.http.ReplayHttpModule
+import com.jraska.github.client.users.test.DeepLinkRecordingComponent
+import com.jraska.github.client.users.test.FakeDeepLinkRecordingModule
 import dagger.BindsInstance
 import dagger.Component
 import javax.inject.Singleton
@@ -30,8 +32,15 @@ class TestUITestApp : BaseApp() {
 }
 
 @Singleton
-@Component(modules = [SharedModules::class, FakeCoreModule::class, ReplayHttpModule::class])
-interface TestAppComponent : AppComponent {
+@Component(
+  modules = [
+    SharedModules::class,
+    FakeCoreModule::class,
+    ReplayHttpModule::class,
+    FakeDeepLinkRecordingModule::class
+  ]
+)
+interface TestAppComponent : AppComponent, DeepLinkRecordingComponent {
   val config: FakeConfig
 
   @Component.Factory

diff --git a/app/src/androidTest/java/com/jraska/github/client/http/ReplayHttpModule.kt b/app/src/androidTest/java/com/jraska/github/client/http/ReplayHttpModule.kt
@@ -10,7 +10,6 @@ import dagger.Module
 import dagger.Provides
 import okhttp3.Interceptor
 import okhttp3.OkHttpClient
-import okhttp3.Response
 import okhttp3.logging.HttpLoggingInterceptor
 import okreplay.AndroidTapeRoot
 import okreplay.OkReplayConfig
@@ -34,7 +33,6 @@ object ReplayHttpModule {
   }
 
   private val REPLAY_MEDIATOR = OkReplayMediator()
-  private const val NETWORK_ERROR_MESSAGE = "You are trying to do network requests in tests you naughty developer!"
 
   private fun createRetrofit(): Retrofit {
     return Retrofit.Builder()
@@ -85,12 +83,7 @@ object ReplayHttpModule {
 
     REPLAY_MEDIATOR.configure(builder)
 
-    val noNetworkInterceptor = object : Interceptor {
-      override fun intercept(chain: Interceptor.Chain): Response {
-        throw UnsupportedOperationException(NETWORK_ERROR_MESSAGE)
-      }
-    }
-    builder.addNetworkInterceptor(noNetworkInterceptor)
+    builder.addInterceptor(MockWebServerInterceptor)
 
     return builder.build()
   }

diff --git a/app/src/debug/AndroidManifest.xml b/app/src/debug/AndroidManifest.xml
@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.jraska.github.client">
+<manifest
+  xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.jraska.github.client">
 
   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
-
+  <application android:networkSecurityConfig="@xml/network_security_config"/>
 </manifest>
diff --git a/app/src/debug/res/xml/network_security_config.xml b/app/src/debug/res/xml/network_security_config.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+  <domain-config cleartextTrafficPermitted="true">
+    <domain includeSubdomains="true">localhost</domain>
+  </domain-config>
+</network-security-config>
diff --git a/core-android-api/src/main/java/com/jraska/github/client/core/android/LinkLauncher.kt b/core-android-api/src/main/java/com/jraska/github/client/core/android/LinkLauncher.kt
@@ -14,7 +14,8 @@ interface LinkLauncher {
   }
 
   enum class Priority(val value: Int) {
-    EXACT_MATCH(0),
-    PATH_LENGTH(1)
+    TESTING(0),
+    EXACT_MATCH(1),
+    PATH_LENGTH(2)
   }
 }
diff --git a/core-android-testing/.gitignore b/core-android-testing/.gitignore
@@ -0,0 +1 @@
+/build
diff --git a/core-android-testing/build.gradle b/core-android-testing/build.gradle
@@ -0,0 +1,35 @@
+apply plugin: 'com.android.library'
+apply plugin: 'kotlin-android'
+apply plugin: 'kotlin-kapt'
+
+android {
+  compileSdkVersion 30
+  defaultConfig {
+    minSdkVersion 24
+  }
+
+  compileOptions {
+    sourceCompatibility JavaVersion.VERSION_1_8
+    targetCompatibility JavaVersion.VERSION_1_8
+  }
+
+  kotlinOptions {
+    jvmTarget = JavaVersion.VERSION_1_8.toString()
+  }
+}
+
+dependencies {
+  implementation project(':core-api')
+  implementation project(':core-android-api')
+
+  kapt rootProject.ext.daggerAnnotationProcessor
+  implementation rootProject.ext.dagger
+
+  implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
+
+  implementation okHttpMockWebServer
+  implementation rootProject.ext.okHttp
+  implementation 'com.squareup.okio:okio:2.10.0'
+
+  implementation 'com.squareup.rx.idler:rx3-idler:0.11.0'
+}
diff --git a/core-android-testing/src/main/AndroidManifest.xml b/core-android-testing/src/main/AndroidManifest.xml
@@ -0,0 +1 @@
+<manifest package="com.jraska.github.client.android.testing"/>
diff --git a/...-android-testing/src/main/java/com/jraska/github/client/android/test/DeepLinksRecorder.kt b/...-android-testing/src/main/java/com/jraska/github/client/android/test/DeepLinksRecorder.kt
@@ -0,0 +1,32 @@
+package com.jraska.github.client.android.test
+
+import android.app.Activity
+import com.jraska.github.client.core.android.LinkLauncher
+import okhttp3.HttpUrl
+
+class DeepLinksRecorder : LinkLauncher {
+  val linksLaunched = mutableListOf<HttpUrl>()
+  private var swallowLinks = false
+
+  override fun priority() = LinkLauncher.Priority.TESTING
+
+  override fun launch(inActivity: Activity, deepLink: HttpUrl): LinkLauncher.Result {
+    linksLaunched.add(deepLink)
+
+    return if (swallowLinks) {
+        LinkLauncher.Result.LAUNCHED // swallows link only as recorded
+    } else {
+        LinkLauncher.Result.NOT_LAUNCHED
+    }
+  }
+
+  fun usingLinkRecording(block: (DeepLinksRecorder) -> Unit) {
+    try {
+      swallowLinks = true
+      block(this)
+    } finally {
+      swallowLinks = false
+      linksLaunched.clear()
+    }
+  }
+}
diff --git a/...roid-testing/src/main/java/com/jraska/github/client/android/test/FakeAndroidCoreModule.kt b/...roid-testing/src/main/java/com/jraska/github/client/android/test/FakeAndroidCoreModule.kt
@@ -0,0 +1,46 @@
+package com.jraska.github.client.android.test
+
+import android.app.Application
+import androidx.lifecycle.ViewModel
+import com.jraska.github.client.core.android.OnAppCreate
+import com.jraska.github.client.core.android.ServiceModel
+import com.squareup.rx3.idler.Rx3Idler
+import dagger.Module
+import dagger.Provides
+import dagger.multibindings.ClassKey
+import dagger.multibindings.IntoMap
+import dagger.multibindings.IntoSet
+import io.reactivex.rxjava3.plugins.RxJavaPlugins
+
+@Module
+object FakeAndroidCoreModule {
+
+  @Provides
+  @IntoMap
+  @ClassKey(ServiceModel::class)
+  internal fun provideServiceModel(): ServiceModel {
+    return object : ServiceModel {} // Make sure the collection is not empty
+  }
+
+  @Provides
+  @IntoMap
+  @ClassKey(ViewModel::class)
+  internal fun provideViewModel(): ViewModel {
+    return object : ViewModel() {} // Make sure the collection is not empty
+  }
+
+  @Provides
+  @IntoSet
+  fun startupRxIdlers() : OnAppCreate {
+    return object : OnAppCreate {
+      override fun onCreate(app: Application) {
+        RxJavaPlugins.setInitComputationSchedulerHandler(
+          Rx3Idler.create("RxJava 3.x Computation Scheduler")
+        )
+        RxJavaPlugins.setInitIoSchedulerHandler(
+          Rx3Idler.create("RxJava 3.x IO Scheduler")
+        )
+      }
+    }
+  }
+}
diff --git a/...esting/src/main/java/com/jraska/github/client/android/test/FakeDeepLinkRecordingModule.kt b/...esting/src/main/java/com/jraska/github/client/android/test/FakeDeepLinkRecordingModule.kt
@@ -0,0 +1,32 @@
+package com.jraska.github.client.users.test
+
+import androidx.test.platform.app.InstrumentationRegistry
+import com.jraska.github.client.android.test.DeepLinksRecorder
+import com.jraska.github.client.core.android.BaseApp
+import com.jraska.github.client.core.android.LinkLauncher
+import dagger.Module
+import dagger.Provides
+import dagger.multibindings.IntoSet
+import javax.inject.Singleton
+
+@Module
+object FakeDeepLinkRecordingModule {
+
+  @Provides
+  @Singleton
+  fun recordingLauncher() = DeepLinksRecorder()
+
+  @Provides
+  @IntoSet
+  fun linkLauncher(launcher: DeepLinksRecorder): LinkLauncher = launcher
+}
+
+interface DeepLinkRecordingComponent {
+  val deepLinksRecorder: DeepLinksRecorder
+}
+
+fun usingLinkRecording(block: (DeepLinksRecorder) -> Unit) {
+  val appComponent = (InstrumentationRegistry.getInstrumentation().targetContext.applicationContext as BaseApp).appComponent
+
+  (appComponent as DeepLinkRecordingComponent).deepLinksRecorder.usingLinkRecording(block)
+}
diff --git a/core-testing/build.gradle b/core-testing/build.gradle
@@ -10,6 +10,7 @@ dependencies {
   kapt rootProject.ext.daggerAnnotationProcessor
   implementation rootProject.ext.dagger
 
+  implementation 'junit:junit:4.13.2'
   implementation 'io.reactivex.rxjava3:rxjava:3.0.12'
 
   implementation rootProject.ext.retrofit

diff --git a/core-testing/src/main/java/com/jraska/github/client/http/FakeHttpModule.kt b/core-testing/src/main/java/com/jraska/github/client/http/FakeHttpModule.kt
@@ -7,12 +7,8 @@ import javax.inject.Singleton
 
 @Module
 class FakeHttpModule {
-  val mockWebServer = MockWebServer()
-
-  @Provides // will be singleton anyway as we have field
-  fun mockWebServer() = mockWebServer
 
   @Provides
   @Singleton
-  fun provideRetrofit() = HttpTest.retrofit(mockWebServer.url("/"))
+  fun provideRetrofit() = HttpTest.retrofit()
 }
diff --git a/core-testing/src/main/java/com/jraska/github/client/http/HttpTest.kt b/core-testing/src/main/java/com/jraska/github/client/http/HttpTest.kt
@@ -1,22 +1,32 @@
 package com.jraska.github.client.http
 
 import okhttp3.HttpUrl
+import okhttp3.HttpUrl.Companion.toHttpUrl
+import okhttp3.Interceptor
 import okhttp3.OkHttpClient
+import okhttp3.Response
 import okhttp3.logging.HttpLoggingInterceptor
 import okhttp3.mockwebserver.MockResponse
 import okhttp3.mockwebserver.MockWebServer
+import org.junit.rules.ExternalResource
 import retrofit2.Retrofit
 import retrofit2.adapter.rxjava3.RxJava3CallAdapterFactory
 import retrofit2.converter.gson.GsonConverterFactory
 import java.io.File
 
 object HttpTest {
-  fun retrofit(baseUrl: HttpUrl): Retrofit {
+  private val DEFAULT_BASE_URL = "https://api.github.com".toHttpUrl()
+
+  fun retrofit(baseUrl: HttpUrl = DEFAULT_BASE_URL): Retrofit {
     return Retrofit.Builder()
       .baseUrl(baseUrl)
-      .client(OkHttpClient.Builder().addInterceptor(HttpLoggingInterceptor { println(it) }.apply {
-        level = HttpLoggingInterceptor.Level.BASIC
-      }).build())
+      .client(
+        OkHttpClient.Builder()
+          .also { if (baseUrl == DEFAULT_BASE_URL) it.addInterceptor(MockWebServerInterceptor) } // TODO: 30/4/21 Hack - unification of network mocking needed
+          .addInterceptor(HttpLoggingInterceptor { println(it) }.apply {
+            level = HttpLoggingInterceptor.Level.BASIC
+          }).build()
+      )
       .addConverterFactory(GsonConverterFactory.create())
       .addCallAdapterFactory(RxJava3CallAdapterFactory.createSynchronous())
       .build()
@@ -51,3 +61,24 @@ internal fun json(path: String): String {
   return String(file.readBytes())
 }
 
+object MockWebServerInterceptor : Interceptor {
+  var mockWebServer: MockWebServer? = null
+
+  override fun intercept(chain: Interceptor.Chain): Response {
+    val webServer = mockWebServer ?: throw UnsupportedOperationException("You are trying to do network requests in tests you naughty developer!")
+
+    val newRequest = chain.request().newBuilder().url(webServer.url(chain.request().url.encodedPath)).build()
+    return chain.proceed(newRequest)
+  }
+}
+
+class MockWebServerInterceptorRule(private val mockWebServer: MockWebServer) : ExternalResource() {
+  override fun before() {
+    MockWebServerInterceptor.mockWebServer = mockWebServer
+  }
+
+  override fun after() {
+    MockWebServerInterceptor.mockWebServer = null
+  }
+}
+
diff --git a/feature/repo/src/test/java/com/jraska/github/client/repo/RepoDetailViewModelTest.kt b/feature/repo/src/test/java/com/jraska/github/client/repo/RepoDetailViewModelTest.kt
@@ -1,11 +1,13 @@
 package com.jraska.github.client.repo
 
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
+import com.jraska.github.client.http.MockWebServerInterceptorRule
 import com.jraska.github.client.http.enqueue
 import com.jraska.github.client.repo.di.DaggerTestRepoComponent
 import com.jraska.github.client.repo.di.TestRepoComponent
 import com.jraska.github.client.repo.model.GitHubApiRepoRepositoryTest
 import com.jraska.livedata.test
+import okhttp3.mockwebserver.MockWebServer
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.Before
 import org.junit.Rule
@@ -16,6 +18,10 @@ internal class RepoDetailViewModelTest {
   @get:Rule
   val testRule = InstantTaskExecutorRule()
 
+  @get:Rule val mockWebServer = MockWebServer()
+
+  @get:Rule val mockWebServerInterceptorRule = MockWebServerInterceptorRule(mockWebServer)
+
   lateinit var component: TestRepoComponent
   lateinit var repoDetailViewModel: RepoDetailViewModel
 
@@ -27,8 +33,8 @@ internal class RepoDetailViewModelTest {
 
   @Test
   fun whenLoadThenLoadsProperRepoDetail() {
-    component.mockWebServer.enqueue("response/repo_detail.json")
-    component.mockWebServer.enqueue("response/repo_pulls.json")
+    mockWebServer.enqueue("response/repo_detail.json")
+    mockWebServer.enqueue("response/repo_pulls.json")
 
     val showRepo = repoDetailViewModel.repoDetail("jraska/github-client")
       .test()
@@ -46,8 +52,8 @@ internal class RepoDetailViewModelTest {
 
   @Test
   fun whenErrorThenLoadsErrorState() {
-    component.mockWebServer.enqueue("response/error.json")
-    component.mockWebServer.enqueue("response/error.json")
+    mockWebServer.enqueue("response/error.json")
+    mockWebServer.enqueue("response/error.json")
 
     val state = repoDetailViewModel.repoDetail("jraska/github-client")
       .test()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		<manifest package="com.jraska.github.client.android.testing"/>