8000 Implement oneshot_lines for coverage by headius · Pull Request #6180 · jruby/jruby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement oneshot_lines for coverage #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2020
Merged

Implement oneshot_lines for coverage #6180

merged 2 commits into from
Apr 17, 2020

Conversation

headius
Copy link
Member
@headius headius commented Apr 17, 2020

This commit also makes some substantial changes to how coverage is
compiled in IR and JIT.

  • Coverage is now independent of tracing and adds behavior to the
    LineNumberInstr
  • Coverage is always available
  • Each covered LineNumber does its own update of coverage data
  • Oneshot mode only updates once and then clears coverage flag
  • JIT uses indy to bind the coverage updating logic, with oneshot
    clearing it to a no-op after the first execution

@headius
Implement oneshot_lines for coverage
1c66bda 
This commit also makes some substantial changes to how coverage is
compiled in IR and JIT.

* Coverage is now independent of tracing and adds behavior to the
  LineNumberInstr
* Coverage is always available
* Each covered LineNumber does its own update of coverage data
* Oneshot mode only updates once and then clears coverage flag
* JIT uses indy to bind the coverage updating logic, with oneshot
  clearing it to a no-op after the first execution
@headius headius added this to the JRuby 9.3.0.0 milestone Apr 17, 2020
enebo
enebo reviewed Apr 17, 2020
View reviewed changes
@headius headius marked this pull request as ready for review April 17, 2020 20:53
@headius headius merged commit 8ddaa56 into jruby:master Apr 17, 2020
@headius headius deleted the new_coverage branch April 17, 2020 21:18
@headius headius mentioned this pull request Apr 17, 2020
Closed
@headius headius mentioned this pull request Apr 29, 2020
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enebo enebo enebo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@headius @enebo
0