feat(api) adds templating to the csv formated out using go's text/template #32
Conversation
|
This is my first ever contribution/pull request so please help me if I missed something. |
|
@eblechschmidt thanks for your contribution! I will review your contribution within the next days and provide feedback |
There was a problem hiding this comment.
Thanks again for your contribution! Overall it looks good 👍🏽 my only remark/concern is the tpl package and the *.tmpl files inside. Instead of having each template inside a separate file I propose that we provide the template directly as a default inside corresponding cmd/*.go file like: tmpl, err := template.New("test").Parse("{{.Count}} example template that is currently inside tpl package {{.Example}}"). What do you think?
| @@ -143,3 +139,12 @@ func printTransactionTable(transactions *comdirect.AccountTransactions) { | |||
| } | |||
| table.Render() | |||
| } | |||
|
|
|||
| func holderName(holderName string) string { | |||
There was a problem hiding this comment.
It seems like that this function is not used or do I miss something? In the past the length of the holderName could be quite long, that's why I limited it to 30 chars.
Implements feature proposed in #22: