8000 Deadlock by shranet · Pull Request #1 · jseow5177/tcp_pool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deadlock #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deadlock #1

wants to merge 1 commit into from

Conversation

shranet
Copy link
@shranet shranet commented Jan 14, 2023 •
edited
Loading

If you are on a slow connection and call TcpConnPool.get more times than maxOpenCount, the last connection may hang. This is because the last connection sends a request to an available connection and hangs here:

tcp_pool/internal/tcp/pool.go

Line 292 in 45ba3f1

p.mu.Lock()

Because the mutex is locked for the first time here and never unlocked:

tcp_pool/internal/tcp/pool.go

Line 203 in 45ba3f1

p.mu.Lock()

I wrote test for this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shranet
0